Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

As an owner or Chapter admin I can ban a participant whom I believe is toxic or who has previously broken my organization's code of conduct. #98

Closed
3 tasks
QuincyLarson opened this issue Oct 20, 2019 · 2 comments
Labels
MVP UI/UX This issue deals with UI/UX

Comments

@QuincyLarson
Copy link
Contributor

QuincyLarson commented Oct 20, 2019

This needs UI and resolvers to handle the requests. The DB schema has user_bans already, so a given user can be banned from a specific Chapter.

Until #814 is in, we can make some progress by implementing the UI for banning users and a resolver to update the DB. After the auth PR is in, we'll need to consider if 'banned' becomes a role that denies you access or if we need to handle banned user access differently.

  • As an owner I can ban anyone except other owners
  • As an admin of a Chapter I can ban anyone in a Chapter except other admins
  • As any other role, I cannot ban anyone

The main thing to check is that requests from unauthorised users fail, but it's also helpful to confirm that the UI reflects their role.

We will also need tests to confirm that banned users can no longer interact with Chapters they are banned from.

@vkWeb vkWeb added the Help Wanted Extra attention is needed label Oct 24, 2019
@QuincyLarson QuincyLarson changed the title As an organizer I can ban a participant whom I believe is toxic or who has previously broken my organization's code of conduct. API: As an organizer I can ban a participant whom I believe is toxic or who has previously broken my organization's code of conduct. Nov 30, 2019
@QuincyLarson QuincyLarson removed the Help Wanted Extra attention is needed label Nov 30, 2019
@QuincyLarson QuincyLarson changed the title API: As an organizer I can ban a participant whom I believe is toxic or who has previously broken my organization's code of conduct. As an organizer I can ban a participant whom I believe is toxic or who has previously broken my organization's code of conduct. Feb 11, 2020
@allella allella added the UI/UX This issue deals with UI/UX label Mar 6, 2021
@ojeytonwilliams ojeytonwilliams self-assigned this Aug 13, 2021
@ojeytonwilliams ojeytonwilliams removed their assignment May 13, 2022
@ojeytonwilliams ojeytonwilliams changed the title As an organizer I can ban a participant whom I believe is toxic or who has previously broken my organization's code of conduct. As an owner or Chapter admin I can ban a participant whom I believe is toxic or who has previously broken my organization's code of conduct. May 13, 2022
@ojeytonwilliams
Copy link
Contributor

Once #1069 goes in, authorisation will need to be modified to take account of ban status.

@ojeytonwilliams
Copy link
Contributor

While not all resolvers are restricted by Authorized decorators, whenever they are restricted, ban status is automatically taken into account.

As a result, it doesn't seem necessary to track this any more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
MVP UI/UX This issue deals with UI/UX
Projects
None yet
Development

No branches or pull requests

4 participants