Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

docs: mention seeding in Development Setup #401

Merged

Conversation

ojeytonwilliams
Copy link
Contributor

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the master branch of Chapter.

It seemed worthwhile to put this in the initial setup guide, rather than leaving it to the detailed DB docs. I suspect most contributors will want to be working with a seeded DB, if only to cut out a little noise from the logs.

@@ -101,6 +101,8 @@ The server will automatically restart anytime you save a `.ts` or `.js` file wit

You can run any command within the container by prefixing it with `docker-compose exec app`, e.g. `docker-compose exec app npm install express`

Next, [seed the DB](#seeding-the-db).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this step also intentionally omitted from the "Natively running" section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the seeding section is immediately after that, so I figured people would naturally go to that after npm run dev. Do you think it would be better to repeat it?

Copy link
Contributor

@timmyichen timmyichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these docs!

@timmyichen timmyichen merged commit b5c83c4 into freeCodeCamp:master Sep 13, 2020
@allella
Copy link
Contributor

allella commented Sep 13, 2020

Thanks @ojeytonwilliams

We're still planning to move the technical docs in the CONTRIBUTING.md, but feel free to commit any changes to README for now.

We've had a number of Windows 10 users with Docker issues, but nobody able to document their steps to fix it so far.

Once the Docker info is updated I'd like to finish #360 by moving the majority of the technical info to CONTRIBUTING.md

@allella
Copy link
Contributor

allella commented Sep 13, 2020

We're also looking for #396 to be merged in and we'll get all this technical info in one place.

Quincy suggested CONTRIBUTING.md as a single technical doc instead of having things spread out all over the place.

The README would become more of an overview of the purpose of the project, with links to the CONTRIBUTING.md

@ojeytonwilliams ojeytonwilliams deleted the docs/mention-seeding branch September 14, 2020 08:16
@ojeytonwilliams
Copy link
Contributor Author

Sounds good. I don't have much to say about Docker except that it works perfectly on Ubuntu and that I'm not surprised there are issues on Windows 10 - it's always a pain.

@allella
Copy link
Contributor

allella commented Nov 19, 2020

@all-contributors add @ojeytonwilliams for infra and docs

@allcontributors
Copy link
Contributor

@allella

I've put up a pull request to add @ojeytonwilliams! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants