-
-
Notifications
You must be signed in to change notification settings - Fork 125
Conversation
@Nirajn2311, thank you for this PR to fix all of these typos. Just a couple of things I noticed: First, could you remove your package-lock.json file? No need to add that. Next, I'm just wondering why you remove the id from the audio tag in the challenges/01-responsive-web-design/applied-accessibility.json file? It seems like the problem with that challenge is not that the audio tag in the example has an id attribute, just that the test doesn't account for users including one. I believe it's the test for that challenge that needs to be updated, rather than the example itself. But that's outside the scope of this PR, so it might be better to submit a separate PR to update that test in the future. |
@scissorsneedfoodtoo I have removed package-lock.json and reverted the id attribute commit. |
@Nirajn2311, shoot, I'm sorry. I didn't explain myself well when I said remove package-lock.json. We don't want to actually delete it, but use No worries, we can revert to an earlier state pretty easily. Here are some steps:
Now package-lock.json should be back in your remote and the Travis build should pass. I'm sorry again for all the trouble. Please take your time and do this all when you can. Just let us know if you run into any problems along the way and hopefully we can get your changes merged soon. |
@scissorsneedfoodtoo sorry about the json file(will fix it tomorrow). Travis failed as it requires a proper format of commit messages and “delete package-lock.json” is not proper. |
@Nirajn2311, no need to apologize! Thank you for investigating. Actually I'm the one who should apologize. I was trying to restore your package-lock.json file, and messed up your commit log in the end. You may be able to use the commands above to roll back my changes/commits and restore the file yourself, though. I'm waiting to hear back from @raisedadead for his git command wizardry before I further mess things up with your PR. Either way, I'm very sorry about that! Hope we can get these checks to pass and get your changes merged soon. |
@scissorsneedfoodtoo I created a new branch and copied it here as the branch had become messy. |
|
Incorrect spelling of penguin(was pengiun)
Incorrect spelling of conversion(was converstion)
Incorrect spelling of declare(was declar)
Incorrect spelling of equality(was equalty)
@raisedadead @scissorsneedfoodtoo @Bouncey All typos and grammatical errors have been fixed. The PR can now be merged. |
👍 👍 Awesome! Everything LGTM 👍 👍 Thank you for your PR to fix all of these typos, @Nirajn2311. We're all looking forward to your next contribution! |
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6)) * **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507)) * **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c)) * **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47) * **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266)) * **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d)) * **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55) ### BREAKING CHANGES * **challenges:** None
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6)) * **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507)) * **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c)) * **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47) * **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266)) * **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d)) * **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55) ### BREAKING CHANGES * **challenges:** None
# [3.0.0](freeCodeCamp/curriculum@v2.0.0...v3.0.0) (2018-06-29) ### Bug Fixes * **challenge:** Fixed the typo for automatically ([freeCodeCamp#48](freeCodeCamp#48)) ([dd046d6](freeCodeCamp@dd046d6)) * **challenge:** Updated tests to avoid confusion ([freeCodeCamp#57](freeCodeCamp#57)) ([7105507](freeCodeCamp@7105507)) * **challenges:** change test for template literals challenge ([freeCodeCamp#37](freeCodeCamp#37)) ([4b1c5eb](freeCodeCamp@4b1c5eb)) * **challenges:** cherry pick pr 17664 & 17672 from main repo ([freeCodeCamp#52](freeCodeCamp#52)) ([2375d0c](freeCodeCamp@2375d0c)) * **challenges:** fixed telephone number validator project ([freeCodeCamp#53](freeCodeCamp#53)) ([2b034e2](freeCodeCamp@2b034e2)), closes [freeCodeCamp#47](freeCodeCamp#47) * **challenges:** fixed typo in css-grid.json ([freeCodeCamp#46](freeCodeCamp#46)) ([e74192e](freeCodeCamp@e74192e)) * **challenges:** grammar fix in css-grid auto-fit challenge ([freeCodeCamp#60](freeCodeCamp#60)) ([a6a0266](freeCodeCamp@a6a0266)) * **challenges:** Typo errors ([freeCodeCamp#39](freeCodeCamp#39)) ([0c0702d](freeCodeCamp@0c0702d)) * **challenges:** update regular expression that fails ([freeCodeCamp#56](freeCodeCamp#56)) ([9fa5907](freeCodeCamp@9fa5907)), closes [freeCodeCamp#55](freeCodeCamp#55) ### BREAKING CHANGES * **challenges:** None
@scissorsneedfoodtoo I believe that spelling error (pengiun instead of penguin) was intentional.
|
@mpmaan, doh! You're absolutely right. I didn't read that challenge description carefully enough. Would you be interested in changing the spelling back to "pengiun", and maybe also making it a bit more clear in the description that the misspelling is intentional? Even making "Note" bold would be a huge improvement. |
@scissorsneedfoodtoo okay, i'll try to fix it |
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Closes freeCodeCamp/#17697,
freeCodecamp/#17699,
freeCodeCamp/#17654,
freeCodeCamp/#17685,
freeCodeCamp/#17725,
freeCodeCamp/#17721
Description
Fixed Typos.