Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank Holiday's? #2

Open
busterbeam opened this issue Dec 31, 2021 · 2 comments
Open

Bank Holiday's? #2

busterbeam opened this issue Dec 31, 2021 · 2 comments

Comments

@busterbeam
Copy link

My friend informed me it was bank holiday this Monday 2022/01/03. but calendar did not have it. Why? Do you check this UK government site?

@lsalvadore
Copy link
Member

calendar works by reading files such as those that you can find in this repository (see calendar.holiday for example).

The bank holiday 2022/01/03 is not present in our files.

According to the link you gave, 2022/01/03 was a bank holiday as a substitute day for New Year's day, so it is not a bank holiday every year. Since UK bank holidays are not fixed, I fear that the only way to manage a calendar file for them would be to do it manually, and then the deskutils/calendar port should be regularly updated to reflect those changes... I fear it would be a bit difficult to maintain.

In my opinion, this repository is not the right place to deal with UK bank holidays and I would recommend you to download and use the ics file from the page you provided.

@stesser (maintainer of deskutils/calendar): What's your opinion? Do you agree or do you think we can deal with UK bank holidays some way?

@stesser
Copy link
Member

stesser commented Apr 23, 2022

The bank holidays in the UK are special insofar as they are moved to the next work day if they happen to fall on a weekend.
And they are even different between England/Wales and Scotland (which has no separate locale).

It is possible to deal with such dates if they are marked in the calendar data file in a special way (e.g. by appending "++") and if the calendar program is updated to support that uncommon (currently unused) modifier to mean: move to next work day.

I could add this functionality to the calendar program, but this is such a special request (but one which would also apply to other countries, for example Japan).

But such an extension of the data format would make our calendar files incompatible with calendar programs on other systems (*BSD, Linux, ...). In the best case they would ignore the second "+" character (where a number is expected, currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants