Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Earlier files and messages deleted" notice to conversation view #1260

Closed
eloquence opened this issue May 21, 2021 · 1 comment
Closed
Labels
enhancement New feature or request ux

Comments

@eloquence
Copy link
Member

eloquence commented May 21, 2021

When the first item (message, file, reply) in the conversation view is not the first item ever created for that source, we want to show a notice near the top of the conversation view: "Earlier files and messages deleted".

Design

The proposed design for this notice can be found here. Pink text is used for annotations and not part of the design.

Acceptance criteria

  • Display the notice when there are items missing at the beginning of a sequence of items in the conversation view.
  • Do not display the notice for any other case.
    • Example: Given a sequence 1 2 3 4 5 or 1 2 3 4 (with strikethrough indicating deletion), the notice should not be displayed.
    • Example: Given a sequence of items 1 2 3 (i.e. all items deleted), the notice should not be displayed. (We will show a separate empty state for this case.)

User Story

As a journalist, I want to know if a message from a source follows a deleted conversation history, so that I can distinguish new from returning sources.

@eloquence eloquence added enhancement New feature or request ux labels May 21, 2021
@eloquence eloquence changed the title Show "Earlier files and messages deleted" notice Add "Earlier files and messages deleted" notice to conversation view May 21, 2021
@sssoleileraaa
Copy link
Contributor

this was resolved as part of #1263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux
Projects
None yet
Development

No branches or pull requests

2 participants