Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6.0-rc1 QA] Client crash when name of user not logged into client (but logged into JI) changed #1411

Closed
rocodes opened this issue Feb 1, 2022 · 0 comments · Fixed by #1415

Comments

@rocodes
Copy link
Contributor

rocodes commented Feb 1, 2022

Description

While performing QA, I changed the name of a user not logged into the client, but who was logged into the JI, and the client crashed while syncing.

Steps to Reproduce

I've tried to reproduce this a couple times and I can't.

  • Log into JI web interface as admin user A. Ensure there are replies to sources from this user.
  • Log into SDW client as journalist B.
  • In the web client, change the name of admin user A

Expected Behavior

  • Journalist A's messages in the client have their new initials

Actual Behavior

Client crash (client window disappears)
from sd-app:

Feb  1 18:11:44 localhost 2022-02-01 18:11:44,566 - root:63(excepthook) ERROR: Unrecoverable error#012Traceback (most recent call last):#012  File "/opt/venvs/securedrop-client/lib/python3.7/site-packages/securedrop_client/gui/widgets.py", line 2037, in _on_update_authenticated_user#012    if user.uuid == self.sender.uuid:#012AttributeError: 'NoneType' object has no attribute 'uuid'
Feb  1 18:11:44 localhost qubes.VMShell-dom0: Traceback (most recent call last):
Feb  1 18:11:44 localhost qubes.VMShell-dom0:   File "/opt/venvs/securedrop-client/lib/python3.7/site-packages/securedrop_client/gui/widgets.py", line 2037, in _on_update_authenticated_user
Feb  1 18:11:44 localhost qubes.VMShell-dom0:     if user.uuid == self.sender.uuid:
Feb  1 18:11:44 localhost qubes.VMShell-dom0: AttributeError: 'NoneType' object has no attribute 'uuid'

Comments

Suggestions to fix, any other relevant information.

@rocodes rocodes changed the title [0.6.0-rc1 QA] Client crash when name of non-logged-in user changed [0.6.0-rc1 QA] Client crash when name of user not logged into client (but logged into JI) changed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant