Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create SecureQLabel subclass of QLabel #369

Closed
redshiftzero opened this issue May 14, 2019 · 0 comments · Fixed by #485
Closed

create SecureQLabel subclass of QLabel #369

redshiftzero opened this issue May 14, 2019 · 0 comments · Fixed by #485
Labels

Comments

@redshiftzero
Copy link
Contributor

We should create a subclass of QLabel to help developers remember where they should be escaping html content, see:

self.message = QLabel(html.escape(text, quote=False))

The SecureQLabel class should be used in all cases where user input is displayed in the UI - namely the message box (SpeechBubble ) and the preview snippet when implemented.

(suggested by this talk on leveraging type system for security and #160)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant