Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.2.1-deb] Crasher: Download after deletion #857

Closed
eloquence opened this issue Mar 4, 2020 · 2 comments · Fixed by #890
Closed

[0.2.1-deb] Crasher: Download after deletion #857

eloquence opened this issue Mar 4, 2020 · 2 comments · Fixed by #890
Assignees
Labels
bug Something isn't working needs/reproducing

Comments

@eloquence
Copy link
Member

Encountered during QA.

  1. A deletion job failed on the first try.
  2. It eventually succeeded, but hit an AppArmor issue ([0.2.1-deb] AppArmor denial causing deletion to not take effect #856).
  3. A subsequent download attempt of a file on a different source caused a crash , see logs. (For the avoidance of confusion: the test file was in fact an .so file.)
@eloquence eloquence added bug Something isn't working needs/reproducing labels Mar 4, 2020
@redshiftzero
Copy link
Contributor

hmm this seems related to #717

@redshiftzero redshiftzero self-assigned this Mar 4, 2020
@redshiftzero
Copy link
Contributor

Tried a couple things:

  • I thought this might be very similar to Deletion in client and re-submission from same source results in error #717, so I deleted a source while a long-running file download was in progress. This worked as expected, the source is deleted, the file download fails but the user is notified gracefully, the job is removed from the queue and no crash occurs.
  • Next I thought perhaps a FileWidget from the deleted source was not getting deleted for some reason, and so the on_file_download slot was running, referencing a File object that no longer exists and causing the crasher (this does seem from the traceback to be what is happening). Tried this scenario in both my dev env and using the python3-pyqt5 package (in case there was divergence from pyqt5), but all works as expected. No errors or crashes.

Regardless of this specific bug it is problematic that an exception occurring in a slot will apparently crash the entire app, we should fix that to log any exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs/reproducing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants