Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/admin/2fa view has ugly yellow syntax code block style for new TOTP secret #1598

Closed
psivesely opened this issue Mar 2, 2017 · 3 comments · Fixed by #5574
Closed

/admin/2fa view has ugly yellow syntax code block style for new TOTP secret #1598

psivesely opened this issue Mar 2, 2017 · 3 comments · Fixed by #5574
Labels
Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean help wanted Issues we would definitely appreciate volunteer help with journalist interface (JI) UX

Comments

@psivesely
Copy link
Contributor

I don't have any particularly wonderful ideas, but even doing a light gray with no border like Github does would look a lot better.
@redshiftzero redshiftzero added the help wanted Issues we would definitely appreciate volunteer help with label Aug 19, 2017
@eloquence
Copy link
Member

eloquence commented Oct 9, 2020 •
edited
Loading

Screenshot showing the yellow blob in question:

Screen Shot 2020-10-09 at 10 24 29-fullpage

@eloquence eloquence added the Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean label Oct 9, 2020
@DrGFreeman
Copy link
Contributor

How about this:

image

  • $color_grey_light background
  • no border
  • Increased lateral padding (20px) and vertical padding (8px)
  • monospace font
  • Increased font size to 1.15em
  • Bold font-weight

Let me know if this is good, I can make adjustments if you want and submit a PR with the changes.

@DrGFreeman DrGFreeman mentioned this issue Oct 11, 2020
Merged
7 tasks
@ninavizz
Copy link
Member

Big legibility improvement, woo! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean help wanted Issues we would definitely appreciate volunteer help with journalist interface (JI) UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify journalist 2fa TOTP secret style DrGFreeman/securedrop
5 participants
@eloquence @psivesely @redshiftzero @ninavizz @DrGFreeman