Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

The value cannot be an empty string. (Parameter 'oldValue') #34

Open
dluc opened this issue Feb 13, 2024 · 1 comment
Open

The value cannot be an empty string. (Parameter 'oldValue') #34

dluc opened this issue Feb 13, 2024 · 1 comment

Comments

@dluc
Copy link
Contributor

dluc commented Feb 13, 2024

Running KM functional tests with 0.9.5, looks like there's a couple of regressions:

image

ItHandlesMissingIndexesConsistently

System.ArgumentException
The value cannot be an empty string. (Parameter 'oldValue')
   at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
   at System.String.Replace(String oldValue, String newValue)
   at System.String.Replace(String oldValue, String newValue, StringComparison comparisonType)
   at FreeMindLabs.KernelMemory.Elasticsearch.ElasticsearchMemory.<GetIndexesAsync>b__7_0(KeyValuePair`2 x)
   at System.Linq.Enumerable.SelectEnumerableIterator`2.MoveNext()
   at System.Collections.Generic.HashSet`1.UnionWith(IEnumerable`1 other)
   at System.Collections.Generic.HashSet`1..ctor(IEnumerable`1 collection, IEqualityComparer`1 comparer)
   at System.Linq.Enumerable.ToHashSet[TSource](IEnumerable`1 source, IEqualityComparer`1 comparer)
   at FreeMindLabs.KernelMemory.Elasticsearch.ElasticsearchMemory.GetIndexesAsync(CancellationToken cancellationToken)
   at Microsoft.KernelMemory.MemoryServerless.ListIndexesAsync(CancellationToken cancellationToken) in service/Core/MemoryServerless.cs:line 143

ItListsIndexes

System.ArgumentException
The value cannot be an empty string. (Parameter 'oldValue')
   at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
   at System.String.Replace(String oldValue, String newValue)
   at System.String.Replace(String oldValue, String newValue, StringComparison comparisonType)
   at FreeMindLabs.KernelMemory.Elasticsearch.ElasticsearchMemory.<GetIndexesAsync>b__7_0(KeyValuePair`2 x)
   at System.Linq.Enumerable.SelectEnumerableIterator`2.MoveNext()
   at System.Collections.Generic.HashSet`1.UnionWith(IEnumerable`1 other)
   at System.Collections.Generic.HashSet`1..ctor(IEnumerable`1 collection, IEqualityComparer`1 comparer)
   at System.Linq.Enumerable.ToHashSet[TSource](IEnumerable`1 source, IEqualityComparer`1 comparer)
   at FreeMindLabs.KernelMemory.Elasticsearch.ElasticsearchMemory.GetIndexesAsync(CancellationToken cancellationToken)
   at Microsoft.KernelMemory.MemoryServerless.ListIndexesAsync(CancellationToken cancellationToken) in service/Core/MemoryServerless.cs:line 143

ES:

docker run -it --rm --name elasticsearch \
  -p 9200:9200 -p 9300:9300 \
  -e "discovery.type=single-node" elasticsearch:8.11.3

Configuration:

      "Elasticsearch": {
        "CertificateFingerPrint": "...",
        "Endpoint": "https://localhost:9200",
        "UserName": "elastic",
        "Password": "...",
        "IndexPrefix": "",
        "ShardCount": 1,
        "Replicas": 0
      },
@afederici75
Copy link
Member

@dluc Sorry I disappeared, lots of stuff happening. I will address this shortly!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants