Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfoBanner title always renders as span tag #338

Open
nlopin opened this issue May 24, 2023 · 2 comments
Open

InfoBanner title always renders as span tag #338

nlopin opened this issue May 24, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@nlopin
Copy link
Contributor

nlopin commented May 24, 2023

When using the InfoBanner component, it is impossible to set the HTML-tag for the message's title. It always uses <span>, which can be incorrect.

What was expected to happen?

  • we should use a headline tag (h3 or similar) by default
  • user can set the level of the tag
@nlopin nlopin added the bug Something isn't working label May 24, 2023
@nlopin nlopin mentioned this issue May 24, 2023
Merged
1 task
@JanHamara
Copy link
Contributor

Hey, so I've changed it to <Headline> in the above MR

@nlopin
Copy link
Contributor Author

nlopin commented May 25, 2023

@JanHamara we should allow picking the level because we don't know the application use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlopin @JanHamara