Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing type exports #445

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: add missing type exports #445

merged 1 commit into from
May 16, 2024

Conversation

martimalek
Copy link
Contributor

What

Adds missing type exports on the Table and and Datepicker components

Why

We were missing types in some projects and had imports like

​import type { DateRange } from '@freenow/wave/lib/types/components/Datepicker/DatepickerRangeInput'

How

  • Export DateRange from `src/components/Datepicker/index.ts``
  • Export SortingDirection from src/components/Table/index.ts

@martimalek martimalek added the bug Something isn't working label May 15, 2024
@martimalek martimalek self-assigned this May 15, 2024
@martimalek martimalek requested a review from dornelasnelson May 15, 2024 12:55
@martimalek martimalek merged commit d5f6eea into main May 16, 2024
10 checks passed
@martimalek martimalek deleted the add-missing-types-exports branch May 16, 2024 07:45
github-actions bot pushed a commit that referenced this pull request May 16, 2024
### [2.1.6](v2.1.5...v2.1.6) (2024-05-16)

### Bug Fixes

* add missing type exports ([#445](#445)) ([d5f6eea](d5f6eea))
Copy link
Contributor

🎉 This PR is included in version 2.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Development

Successfully merging this pull request may close these issues.

3 participants