Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add two new neutral colors and map them to new semantic color #457

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

jahe
Copy link
Contributor

@jahe jahe commented Jun 13, 2024

What

Our designer asked us to add two new neutral base colors to the modern theme and add new semantic colors while deprecating others.

Media

image image image

Why

We are redefining the background and surface tokens and will need these extra tones. (neutral-10, neutral-800)

How

  • Add new colors and correct the existing neutral colors (some they were slightly off but it's not significant so should't be considered a breaking change).
  • Add new semantic color background-page-elevation-0
  • Change color for background-page-default slightly

@jahe jahe changed the title feat: add two new neutral colors to modern base colors feat: add two new neutral colors and map them to new semantic colors Jun 13, 2024
@jahe jahe requested a review from arturmiglio June 13, 2024 16:18
src/essentials/Colors/Colors.ts Outdated Show resolved Hide resolved
src/essentials/Colors/types.ts Outdated Show resolved Hide resolved
src/essentials/Colors/Colors.ts Outdated Show resolved Hide resolved
src/essentials/Colors/types.ts Outdated Show resolved Hide resolved
@jahe jahe changed the title feat: add two new neutral colors and map them to new semantic colors feat: add two new neutral colors and map them to new semantic color Jun 18, 2024
@jahe jahe requested review from arturmiglio and martimalek June 18, 2024 23:07
@jahe jahe merged commit 97bb713 into main Jun 20, 2024
10 checks passed
@jahe jahe deleted the add-new-neutral-colors branch June 20, 2024 09:52
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
## [2.3.0](v2.2.2...v2.3.0) (2024-06-20)

### Features

* add two new neutral colors and a new semantic color ([#457](#457)) ([97bb713](97bb713))
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants