-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add two new neutral colors and map them to new semantic color #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahe
requested review from
nlopin,
martimalek,
div-Leo,
jonotrujillo and
arturmiglio
as code owners
June 13, 2024 10:34
arturmiglio
approved these changes
Jun 13, 2024
jahe
changed the title
feat: add two new neutral colors to modern base colors
feat: add two new neutral colors and map them to new semantic colors
Jun 13, 2024
arturmiglio
suggested changes
Jun 17, 2024
martimalek
suggested changes
Jun 17, 2024
jahe
changed the title
feat: add two new neutral colors and map them to new semantic colors
feat: add two new neutral colors and map them to new semantic color
Jun 18, 2024
arturmiglio
approved these changes
Jun 19, 2024
martimalek
approved these changes
Jun 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
## [2.3.0](v2.2.2...v2.3.0) (2024-06-20) ### Features * add two new neutral colors and a new semantic color ([#457](#457)) ([97bb713](97bb713))
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Our designer asked us to add two new neutral base colors to the modern theme and add new semantic colors while deprecating others.
Media
Why
We are redefining the background and surface tokens and will need these extra tones. (neutral-10, neutral-800)
How
background-page-elevation-0
background-page-default
slightly