@@ -951,7 +951,8 @@ int test_codec_selection(struct context *ctx)
951
951
TEST_1 (m = b_sdp -> sdp_media ); TEST_1 (!m -> m_rejected );
952
952
TEST_1 (rm = m -> m_rtpmaps ); TEST (rm -> rm_pt , 3 );
953
953
TEST_S (rm -> rm_encoding , "GSM" );
954
- /* Not use same payload as remote so 97 from answer */
954
+ /* We do not expect payload type as 96 here anymore as we stopped using the same payload type as remote had
955
+ since 4703f3ade78a89cdc37f673b5bde3435ab71dc27 so 97 stays. */
955
956
TEST_1 (rm = rm -> rm_next ); TEST (rm -> rm_pt , 97 );
956
957
TEST_S (rm -> rm_encoding , "G729" );
957
958
TEST_1 (rm = rm -> rm_next ); TEST (rm -> rm_pt , 111 );
@@ -1007,10 +1008,10 @@ int test_codec_selection(struct context *ctx)
1007
1008
TEST_S (rm -> rm_encoding , "CN" );
1008
1009
TEST_1 (!rm -> rm_next );
1009
1010
1010
- /* Answering end matches payload types
1011
- then sorts by local preference,
1012
- not use same payload type as remote,
1013
- then select best codec => GSM with pt 3 */
1011
+ /* Answering end matches payload types then sorts by local preference,
1012
+ then select best codec => GSM with pt 3
1013
+ Note : we stopped using the same payload type as remote had
1014
+ since 4703f3ade78a89cdc37f673b5bde3435ab71dc27 so not expect 97 here. */
1014
1015
TEST_1 (m = b_sdp -> sdp_media ); TEST_1 (!m -> m_rejected );
1015
1016
TEST_1 (rm = m -> m_rtpmaps ); TEST (rm -> rm_pt , 3 );
1016
1017
TEST_S (rm -> rm_encoding , "GSM" );
@@ -1264,7 +1265,8 @@ int test_codec_selection(struct context *ctx)
1264
1265
TEST_1 (!m -> m_next );
1265
1266
1266
1267
TEST_1 (m = b_sdp -> sdp_media ); TEST_1 (!m -> m_rejected );
1267
- /* Not use same payload as remote so 97 from answer */
1268
+ /* We do not expect payload type as 96 here anymore as we stopped using the same payload type as remote had
1269
+ since 4703f3ade78a89cdc37f673b5bde3435ab71dc27 so 97 stays. */
1268
1270
TEST_1 (rm = m -> m_rtpmaps ); TEST (rm -> rm_pt , 97 );
1269
1271
TEST_S (rm -> rm_encoding , "G729" );
1270
1272
TEST_1 (rm = rm -> rm_next ); TEST (rm -> rm_pt , 111 );
@@ -2242,11 +2244,11 @@ int test_address_selection(struct context *ctx)
2242
2244
TEST_OC_ADDRESS (a , "2001:1508:1003::21a:a0ff:fe71:813" , ip6 );
2243
2245
TEST_VOID (soa_terminate (a , NULL ));
2244
2246
2245
- /* SOATAG_AF(SOA_AF_IP4_IP6) and SOATAG_USER_O_LINE() tag remove so, o= mentions IP6 => select IP4 */
2246
- n = soa_set_user_sdp (a , 0 , "o=- 1 1 IN IP4 ::\r\n"
2247
+ /* SOATAG_AF(SOA_AF_IP4_IP6) and SOATAG_USER_O_LINE() tag remove from so, o= mentions IP6 => select IP6 */
2248
+ n = soa_set_user_sdp (a , 0 , "o=- 1 1 IN IP6 ::\r\n"
2247
2249
"m=audio 5008 RTP/AVP 0 8" , -1 ); TEST (n , 1 );
2248
2250
n = soa_generate_offer (a , 1 , test_completed ); TEST (n , 0 );
2249
- TEST_OC_ADDRESS (a , "11.12.13.14 " , ip4 );
2251
+ TEST_OC_ADDRESS (a , "2001:1508:1003::21a:a0ff:fe71:813 " , ip6 );
2250
2252
TEST_VOID (soa_process_reject (a , NULL ));
2251
2253
2252
2254
/* SOATAG_AF(SOA_AF_IP4_IP6), c= uses non-local IP6
0 commit comments