-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome Web Store rejection for obfuscated code #84
Comments
I think that our Dropping the scope hoisting probably produces more code but maybe it’s not a bad idea if it preserves the function names. |
Does your extension work for you with that flag? It appears to break it: parcel-bundler/parcel#8071 (comment) |
Yeah, Ive just done a test and everything is working as expected so far. Takes around 2-3 days for my extension to be approved. Ill report back the results asap. |
Hey there! I can confirm that my extension has been published with the above fix, and it works as expected. To be absolutely explicit, here is my build command
|
Hey! Thanks for the sweet boilerplate! Its been working really well so far.
Just letting you know that I was rejected from CWS using this boilerplate yesterday for obfuscated code.
I had seen this issue you submitted parcel-bundler/parcel#6092
I didnt have any luck applying your suggestions. However, Im pending another review with
--no-scope-hoist
which seems to have removed the hexi from all the functions. Ill see if that works and report back...Filing an issue incase others run into the same thing from CWS.
The text was updated successfully, but these errors were encountered: