Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MV3 reinjects on service worker restart #7

Closed
twschiller opened this issue Jan 5, 2024 · 2 comments · Fixed by #9
Closed

MV3 reinjects on service worker restart #7

twschiller opened this issue Jan 5, 2024 · 2 comments · Fixed by #9
Assignees
Labels

Comments

@twschiller
Copy link

@fregante
Copy link
Owner

fregante commented Jan 6, 2024

onStartup refers to the browser startup, not the extension.

onInstalled covers the common scenario, but it won't work if they user re-enables a disabled extension, or if you reload it during development.

I recently created an event for this, based on chrome.session, I'll try using it here: https://github.com/fregante/webext-events/blob/main/source/on-extension-start.md

It seems that soon they'll work on the onEnabled event, which is the right API for us:

@fregante fregante self-assigned this Jan 6, 2024
@fregante fregante added the bug label Jan 6, 2024
@twschiller
Copy link
Author

twschiller commented Jan 6, 2024

At least in our project, it's not a high priority as we guard against re-injection. I just wanted to capture the issue as something to be aware of (and could impact other users of this library)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants