Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up cache in Manifest v3 #48

Closed
sb8244 opened this issue Sep 10, 2024 · 4 comments
Closed

Cleaning up cache in Manifest v3 #48

sb8244 opened this issue Sep 10, 2024 · 4 comments

Comments

@sb8244
Copy link

sb8244 commented Sep 10, 2024

I was looking through the code for how chrome.alarms is used, and I see there's a check for if (!isBackgroundPage()). This will return in the case of manifest v3, and the alarms and cleanup will not happen.

@fregante
Copy link
Owner

PR welcome to replace it with isBackground

@sb8244
Copy link
Author

sb8244 commented Sep 11, 2024

Thank you!

@sb8244
Copy link
Author

sb8244 commented Sep 12, 2024

@fregante Is it possible to cut a release, or is there a way to cleanly use this in a pre-release state?

@fregante
Copy link
Owner

I’m computer-less at the moment so I won’t be able to release it this week. For now you might be able to run npm install fregante/webext-storage-cache and hope that npm builds it from GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants