luci-app-ffwizard-falter: Assistent fails with Lua stack trace when entering mesh IP without CIDR notation

[jakoblell]

Maintainer: @pmelange
Environment: EAP225-outdoor-v3, Current Snapshot built via falter-builter

Description:

I've just set up a new Freifunk router and accidentally entered the mesh IP address as a plain address instead of a full CIDR notation with the /32 affix in the last step of the asisstent. When trying to finish the assistent, it was failing with the following Lua stack trace:

...b/lua/luci/model/cbi/freifunk/assistent/wireless.lua:264: attempt to index local 'dhcpmeshnet' (a nil value)
stack traceback:
	...b/lua/luci/model/cbi/freifunk/assistent/wireless.lua:264: in function 'write'
	...b/lua/luci/model/cbi/freifunk/assistent/wireless.lua:110: in function 'parse'
	/usr/lib/lua/luci/cbi.lua:248: in function 'parse'
	/usr/lib/lua/luci/cbi.lua:248: in function 'parse'
	/usr/lib/lua/luci/cbi.lua:713: in function 'parse'
	/usr/lib/lua/luci/dispatcher.lua:1536: in function '_form'
	/usr/lib/lua/luci/dispatcher.lua:1059: in function 'dispatch'
	/usr/lib/lua/luci/dispatcher.lua:483: in function </usr/lib/lua/luci/dispatcher.lua:482>

This is an error which can easily happen to normal users and should therefore be handled more gracefully (i.e. highlighting the text field with the incorrect input, this is already implemented for other errors such as a missing meshing IP for one of the radio interfaces).

Version info:

opkg search /usr/lib/lua/luci/model/cbi/freifunk/assistent/wireless.lua
luci-app-ffwizard-falter - git-22.120.34984-b41e05d

[Akira25]

Just tested this on a 1.2.2-node. This error doesn't happen there. As only snapshot-images might be affected, postponing this to a later release.