Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment in site #5

Open
ghost opened this issue Mar 19, 2015 · 3 comments
Open

Comment in site #5

ghost opened this issue Mar 19, 2015 · 3 comments
Labels

Comments

@ghost
Copy link

ghost commented Mar 19, 2015

Site-select does not work with sites which use comments.

@do9xe do9xe added the bug label Mar 19, 2015
@do9xe
Copy link
Contributor

do9xe commented Mar 19, 2015

This is a known issue. If you provide a filter line which removes all lua comments we can fix it real quick.
I would suggest a for-loop, which removes every comment in every file in a given directory.
write me on twitter or facebook for further planing (Hendrik Lüth or @do9xe)

@ghost
Copy link
Author

ghost commented Mar 19, 2015

for f in extra/*; do sed -i /^--/d $f; done in bash will remove all lines starting with "--" in the folder extra

@do9xe
Copy link
Contributor

do9xe commented Mar 19, 2015

Thanks :)
What about the comments, which are longer than a line, marked like this:
--[[comment]]--
Add a filter rule for this with your first one and try to apply it. If working, add them to the top of the script and add a pullrequest :) try to not use the /extra directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant