Server errors don't actually log

[halkeye]

Looking at https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/logging/logrus/ctxlogrus/context.go#L36 it looks like you need to call ctxlogrus.ToContext(context) first, before you can call extract.

I can't find ToContext being called. This makes https://github.com/freifunkMUC/wg-access-server/blob/master/internal/services/middleware.go#L22 a null logger.

[DasSkelett]

Are you sure this doesn't work? Manually triggering an error logs this:

ERRO[0010]device_service.go:46 test error  grpc.method=ListDevices grpc.service=proto.Devices grpc.start_time="2022-03-02T14:08:21+01:00" span.kind=server system=grpc trace.id=84adf761-1751-49e3-b3ec-d770e88d92b8
ERRO[0010]options.go:224 finished unary call with code Internal  error="rpc error: code = Internal desc = failed to retrieve devices" grpc.code=Internal grpc.method=ListDevices grpc.service=proto.Devices grpc.start_time="2022-03-02T14:08:21+01:00" grpc.time_ms=0.691 span.kind=server system=grpc trace.id=84adf761-1751-49e3-b3ec-d770e88d92b8

I'm not familiar with this logging infrastructure, and the docs are a bit confusing. But from what I can tell, errors that happen in the grpc API do get logged.

[halkeye]

Ah it probably works for grpc. I was having oauth errors, so not the grpc

Maybe the better solution is for the middleware to check if extract returns something.ill poke at it more.

[halkeye]

okay so grpc-ecosystem/go-grpc-middleware#467 describes the issue pretty well. Sadly there's no way to opt out of this behavior.