Skip to content

Commit ae7ee47

Browse files
committed
[fuchsia][shader warmup] Fixed SkpWarmupTest
This test regressed due to flutter#23488 and this regression was silent due to flutter/flutter#78277 Credit to @gnoliyil for actually putting together the fix.
1 parent 75997c5 commit ae7ee47

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

shell/platform/fuchsia/flutter/tests/engine_unittests.cc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ class EngineTest : public ::testing::Test {
5959
// otherwise we segfault creating the VulkanSurfaceProducer
6060
auto loop = fml::MessageLoopImpl::Create();
6161

62-
fuchsia::ui::scenic::SessionPtr session_ptr;
63-
scenic::Session session(std::move(session_ptr));
62+
context_ = sys::ComponentContext::CreateAndServeOutgoingDirectory();
63+
scenic_ = context_->svc()->Connect<fuchsia::ui::scenic::Scenic>();
64+
scenic::Session session(scenic_.get());
6465
surface_producer_ = std::make_unique<VulkanSurfaceProducer>(&session);
6566

6667
Engine::WarmupSkps(&concurrent_task_runner_, &raster_task_runner_,
@@ -71,6 +72,9 @@ class EngineTest : public ::testing::Test {
7172
MockTaskRunner concurrent_task_runner_;
7273
MockTaskRunner raster_task_runner_;
7374
std::unique_ptr<VulkanSurfaceProducer> surface_producer_;
75+
76+
std::unique_ptr<sys::ComponentContext> context_;
77+
fuchsia::ui::scenic::ScenicPtr scenic_;
7478
};
7579

7680
TEST_F(EngineTest, SkpWarmup) {

0 commit comments

Comments
 (0)