Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes handleResponse #153

Open
freizl opened this issue Sep 18, 2022 · 3 comments
Open

Fixes handleResponse #153

freizl opened this issue Sep 18, 2022 · 3 comments
Labels
enhancement hoauth2

Comments

@freizl
Copy link
Owner

freizl commented Sep 18, 2022

Fixes this TODO.

  if HT.statusIsSuccessful (responseStatus rsp)
    then Right $ responseBody rsp
    else -- TODO: better to surface up entire resp so that client can decide what to do when error happens.
      Left $ responseBody rsp
@freizl freizl added the hoauth2 label Sep 29, 2022
@freizl freizl added the bug label Oct 18, 2022
@freizl
Copy link
Owner Author

freizl commented Oct 18, 2022

The big problem is when error, which has empty response body, upstream has no idea what happened.

@freizl
Copy link
Owner Author

freizl commented Nov 9, 2022

Work around added in this commit: 58599ea
Serialize entire response when body is empty

@freizl
Copy link
Owner Author

freizl commented Jul 10, 2023

Maybe consider to surface up entire Response X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hoauth2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@freizl