Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git-fetch-with-cli #66

Closed
epage opened this issue Sep 24, 2021 · 4 comments · Fixed by #129
Closed

Support git-fetch-with-cli #66

epage opened this issue Sep 24, 2021 · 4 comments · Fixed by #129

Comments

@epage
Copy link
Contributor

epage commented Sep 24, 2021

And accompanying env variable CARGO_NET_GIT_FETCH_WITH_CLI

See https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

From rust-lang/cargo#5914

@epage
Copy link
Contributor Author

epage commented Jul 31, 2023

A CLI fallback won't be necessary anymore as gix aims to behave just like git

Bold :) but meh

@Byron Byron reopened this Aug 1, 2023
@Byron
Copy link
Collaborator

Byron commented Aug 1, 2023

Apologies, this issue was auto-closed which wasn't actually my intention nor my doing even though GitHub claims it was 😅. Could you recheck and let me know what concretely doesn't work? Because it gix should behave like git by default.

@epage
Copy link
Contributor Author

epage commented Aug 1, 2023

Like I said, "meh". For me, it was (1) parity with cargo and (2) because people sometimes use the escape hatch. I myself don't use this and don't have particular test cases but was interested more on behalf of the users of my applications.

@Byron
Copy link
Collaborator

Byron commented Aug 2, 2023

Thanks for elaborating the "meh" :).

For me, it was (1) parity with cargo and (2) because people sometimes use the escape hatch.

From what I could gather, support-fetch-with-cli was added to make certain git transport configurations work that can't be configured in cargo or aren't supported in git2. Being 'bold' once more I argue that gix powered libraries will behave like git and pick up all relevant configuration as well, thus an escape hatch shouldn't be required. If nonetheless something doesn't work, I consider this a bug in gix that should be fixed, rather than worked around.

With that in mind, I am closing this issue and hope that you can CC me in issues that arise from gix not performing as it should (I also searched the issues of cargo-release but couldn't find anything - probably that doesn't mean more than that I definitely need some pointers :)).

Thank you.

@Byron Byron closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants