Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: const fn support #8

Closed
korken89 opened this issue Oct 10, 2021 · 1 comment · Fixed by #9
Closed

Feature request: const fn support #8

korken89 opened this issue Oct 10, 2021 · 1 comment · Fixed by #9

Comments

@korken89
Copy link

Hi,

Thanks for this minimal lib!
I'd like to make a feature request, to move the implementations to const fn and have the trait call the const fn methods.
This would allow for compile time finding of GCD values.
@TDHolmes
Copy link
Contributor

I think all that is needed is to either wait for const_swap or just do it ourselves with a temp variable

This was referenced Dec 12, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch underlying implementations to be const TDHolmes/rust-gcd
2 participants
@korken89 @TDHolmes