Rename threads param to num_threads.
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the change, but it seems not yet complete. |
frewsxcv
force-pushed
the
num-threads
branch
9 times, most recently
from
2d6bf42 to
7f069c6
Compare
|
@dns2utf8 Want to review this? |
| self.set_num_threads(num_threads) | ||
| } | ||
|
|
||
| /// Sets the number of threads to use as `num_threads`. |
There was a problem hiding this comment.
Maybe rephrase to "number of workers" or "number of worker-threads"
|
@frewsxcv with pleasure. |
|
Could you increase the version number in |
Going to do it when I release the version |
An attempt to differentiate/clarify the parameter name.
|
Thanks for the review! Will merge if the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to differentiate/clarify the parameter name.