Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replace = FALSE to add_resource() #227

Closed
peterdesmet opened this issue Jul 8, 2024 · 1 comment · Fixed by #231
Closed

Add replace = FALSE to add_resource() #227

peterdesmet opened this issue Jul 8, 2024 · 1 comment · Fixed by #231
Assignees
@sannegovaert
Labels
complexity:low Likely not complex to implement function:add/remove Functions add_resource(), remove_resource()
Milestone
1.2.0

Comments

@peterdesmet
Copy link
Member

Sometimes you want to edit a resource in place. add_resource() currently forbids that.

  • Alternative 1: have a replace = TRUE attribute in add_resource() (default FALSE)
  • Alternative 2: have a replace_resource() function

I prefer alternative 1. We will be to use this attribute/function in inbo/camtrapdp#74
@peterdesmet peterdesmet added function:add/remove Functions add_resource(), remove_resource() complexity:low Likely not complex to implement labels Jul 8, 2024
@peterdesmet peterdesmet added this to the 1.2.0 milestone Jul 8, 2024
@PietrH
Copy link
Member

PietrH commented Jul 9, 2024

I prefer replace = TRUE

@sannegovaert sannegovaert self-assigned this Jul 9, 2024
@sannegovaert sannegovaert mentioned this issue Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sannegovaert sannegovaert

Labels
complexity:low Likely not complex to implement function:add/remove Functions add_resource(), remove_resource()
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Update add_resource() frictionlessdata/frictionless-r
3 participants
@peterdesmet @sannegovaert @PietrH