Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Integration Instructions for Starter Frontend #90

Closed
jarednorman opened this issue Nov 13, 2023 · 1 comment · Fixed by #91
Closed

Provide Integration Instructions for Starter Frontend #90

jarednorman opened this issue Nov 13, 2023 · 1 comment · Fixed by #91

Comments

@jarednorman
Copy link
Contributor

I installed this on a new store using the starter frontend and found that out of the box the promotions I was creating weren't working when I put the coupon code in on the cart page. This was because the CouponCodesController references the stock Solidus::PromotionHandler::Coupon. Swapping it out for SolidusFriendlyPromotions::PromotionHandler::Coupon fixes the issue.

I'm not sure if there are other touchpoints that need to be handled, but we should probably document at least this touchpoint.

@mamhoff
Copy link
Contributor

mamhoff commented Nov 14, 2023

I'll get to that shortly, for now there's a PR to solidus_starter_frontend to make this not an issue by default for new stores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants