Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to use a custom list instead of the default ul #147

Open
dragos-boisteanu opened this issue Nov 10, 2022 · 6 comments
Open

option to use a custom list instead of the default ul #147

dragos-boisteanu opened this issue Nov 10, 2022 · 6 comments

Comments

@dragos-boisteanu
Copy link

Hi,

Could it be made in a way that I can use my own list instead of the default ul

<ul class="atwho-ul">
?

For example allow to use a virtuall scroller in case the members list is very long, 1000+ members.

Thank you

@fritx
Copy link
Owner

fritx commented Nov 10, 2022

@dragos-boisteanu would be glad to help :)

@dragos-boisteanu
Copy link
Author

do you know a virtual scroller that works well for vue2 and would fit well with the project ?

I know about this one https://github.com/tangbc/vue-virtual-scroll-list , it's pretty good for simple components like those that might be inside a mentions list but it gets slow when the components are too complex, like a chat message.
A custom solution would be way better, but I am not able to make one.

Next week I could try to integrate it and replace the ul.

@fritx
Copy link
Owner

fritx commented Nov 11, 2022

do you know a virtual scroller that works well for vue2 and would fit well with the project ?

any contribution is appreciated ;)

but I think a scoped slot support would be better here --

  1. it doesn't matter which scrolling library the user uses, but can integrate it him/herself.
  2. no need to depend on a library directly from vue-at

maybe we provide a scoped slot feature support here and add a demo to the documentation?

@fritx
Copy link
Owner

fritx commented Nov 11, 2022

I have a PoC here, adding scoped-slot support for the <ul>:
https://github.com/fritx/vue-at/commits/feat/custom-list

  • plain custom <ul>
  • vue-virtual-scroller integrated
  • vue-virtual-scroll-list integrated

@dragos-boisteanu
Copy link
Author

Thank you very much. I will give it a try soon.

@fritx
Copy link
Owner

fritx commented Nov 29, 2022

I have a PoC here, adding scoped-slot support for the <ul>

  • plain custom <ul>
  • vue-virtual-scroller integrated
  • vue-virtual-scroll-list integrated

@dragos-boisteanu vue-virtual-scroll-list has also been integrated:
https://github.com/fritx/vue-at/commits/feat/custom-list

Is this implementation and corresponding usage acceptable for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants