Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syrinscape volume control under Global Volume Controls is not set correctly on new install. #86

Closed
voodoofrog opened this issue Mar 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@voodoofrog
Copy link

On a new install the control starts at the halfway point when it is actually full volume and to actually put it to half volume you have to set it to it full and then back to half.

To Reproduce

  1. Set up a fresh instance of Syrincontrol with no adjustments made.
  2. Adjust the volume control to 100%.
  3. Adjust the volume control to 50%.

The volume control should reflect the actual volume of the playing mood.

I would expect the volume to start at 100% or for it to get louder when adjusted to 100% in step 2.

Details

Additional context

I have also had instances where after changing mood, the volume of the playing mood seems to have ignored my global volume setting and gone back to being louder than expected, although I cannot reproduce this in fresh world with no other modules, so I'm not entirely sure what happened.

@voodoofrog voodoofrog added the bug Something isn't working label Mar 30, 2023
@frondeus
Copy link
Owner

frondeus commented Apr 4, 2023

Hmm, yeah there is definitely something wrong, its probably aftermath after #58 .

@frondeus
Copy link
Owner

frondeus commented Apr 7, 2023

Okay, yeah. In the store initialization, I still had a default value of 50 (because the foundry volume is stored in the range of 0-100).
Meanwhile, syrinscape uses the range 0.0-1.0 :)

Fixed it in 1a0d6cd

@frondeus frondeus closed this as completed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants