New clippy lint in Rust 1.71.0, items_after_test_module, affecting integration tests

[brooksprumo]

Hi folks!

Looks like Rust 1.71.0 added a new lint¹ to Clippy that seem to be affecting test-case. Here's output from one:

warning: items were found after the testing module
   --> core/tests/epoch_accounts_hash.rs:253:1
    |
253 |   #[test_case(TestEnvironment::new()                      ; "without snapshots")]
    |   ^------------------------------------------------------------------------------
    |   |
    |  _in this procedural macro expansion
    | |
254 | | #[test_case(TestEnvironment::new_with_snapshots(80, 40) ; "with snapshots")]
255 | | fn test_epoch_accounts_hash_basic(test_environment: TestEnvironment) {
256 | |     solana_logger::setup();
...   |
664 | |     }
665 | | }
    | |_^
    |
    = help: move the items to before the testing module was defined
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module
    = note: `#[warn(clippy::items_after_test_module)]` on by default
    = note: this warning originates in the attribute macro `test_case` (in Nightly builds, run with -Z macro-backtrace for more info)

This seems to affect integration tests (ones in the tests directory) and not unit tests. As a work-around, I can #[allow] the clippy lint, but wasn't sure if there was something else I could do also.

Let me know if you'd like more information and/or steps to reproduce. Thanks in advance!

Footnotes

1. https://rust-lang.github.io/rust-clippy/master/index.html#/items_after_test_module ↩

[frondeus]

Hi!

This seems to be related - I thought it was already fixed on clippy side
#122

[frondeus]

Okay it seems that the fix on the clippy side didn't make to 1.71.0 release and should be released with 1.72 :)

[brooksprumo]

Thanks for the prompt replies, and additional info! I'll close this issue as it appears resolved to me.