Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navi as react-native router #154

Closed
gut4 opened this issue Dec 3, 2019 · 3 comments
Closed

navi as react-native router #154

gut4 opened this issue Dec 3, 2019 · 3 comments

Comments

@gut4
Copy link

gut4 commented Dec 3, 2019

Is it possible to use navi as react-native router?

@jamesknelson
Copy link
Collaborator

It may be possible, but I've never tried it myself. If you do try this, you'd need to write your own integrations for e.g. deep linking and the Android back button.

@gut4
Copy link
Author

gut4 commented Dec 5, 2019

Looks like it can work with Navi.createMemoryNavigation and useNavigation
But there is a problem with hashScroll:

window.scroll(left, top)

So for react-native we need to disable hashScroll somehow as there is no window

@jamesknelson
Copy link
Collaborator

I see. Seems like there needs to be an option to pass a HashScrollBehavior of none.

If you're up to submitting a PR, this should be a pretty easy change. Otherwise I'll see if I can give it a shot this weekend or next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants