Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default fetcher #1

Open
jamesknelson opened this issue Sep 10, 2019 · 3 comments
Open

Add a default fetcher #1

jamesknelson opened this issue Sep 10, 2019 · 3 comments

Comments

@jamesknelson
Copy link
Contributor

Polestar should include a default Fetcher, implemented using babel, babel-plugin-detective, and which fetches packages from unpkg.

This is a lot of code, so it should probably live in a separate package. It also makes sense to keep it separate so that you can decide on your own caching strategy.

I'm finally adding this because I just ran into an issue in my own fetcher where nested package.json files like https://unpkg.com/browse/dom-helpers@5.1.0/removeClass/package.json don't work, and while I can fix this myself, I think it may make sense to share this code between everyone using Polestar.

cc @nickjanssen

@jamesknelson jamesknelson changed the title Add an default fetcher Add a default fetcher Sep 10, 2019
@thangngoc89
Copy link

@jamesknelson I have an open source one written in ReasonML, I can make it a separate repo if you're interested

@jamesknelson
Copy link
Contributor Author

Sure, something is better than nothing! I've got a closed source one too which I should open source, but there's a lot of code.

For something official, I think it would be nice to keep it in vanilla JS or TypeScript so that it's easier for people to contribute to.

@thangngoc89
Copy link

I think it could be served as a reference implementation. Will try to separate it from my project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants