Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

还存在广播到多窗口的问题 #174

Closed
Jiangshuon opened this issue Nov 8, 2023 · 6 comments
Closed

还存在广播到多窗口的问题 #174

Jiangshuon opened this issue Nov 8, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Jiangshuon
Copy link

大佬,今日笔记的广播到多窗口还存在问题,多窗口下,新建第一个日记没问题,然后紧接着再新建一个日记(其他笔记本的),又会广播到其他所有窗口

@frostime frostime self-assigned this Nov 8, 2023
@frostime frostime added the bug Something isn't working label Nov 8, 2023
@frostime
Copy link
Owner

frostime commented Nov 8, 2023

#171

@frostime
Copy link
Owner

我重新试了一下,发现这个是内核的问题。

内核当中,如果你新建了一个日记,那么这个事件就是会自动广播到全体窗口中。

image

所以具体到插件的表现就是,如果你打开的是一个已经创建的日记有「√」符号,那么就不会广播到其他窗口;但是如果你打开的是一个不存在的日记,那么新建并打开这个日记的行为就是会广播到别的窗口。

总结就是:没招,内核写死了。除非我不用内核的 API,而是自己实现创建日记的功能——但是内核API自动实现了读入日记模板的功能,如果不用API需要自己手动处理,会很麻烦,所以我的建议是忍忍算了。

@Jiangshuon
Copy link
Author

对了大佬,我直接按Alt+5,确实会广播。那这样算是思源内核的bug吧?应该给D大提issue吗

@frostime
Copy link
Owner

frostime commented Nov 11, 2023

对了大佬,我直接按Alt+5,确实会广播。那这样算是思源内核的bug吧?应该给D大提issue吗

不算 bug,看代码是设计如此,但是我觉得可以提一下看看能不能改掉。这个广播行为感觉没什么必要。

@frostime
Copy link
Owner

我先关了,有事情就在这下面说。

@Jiangshuon
Copy link
Author

好的,那我去提下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants