Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-create-library command does not create a MainActivity.java #88

Closed
jerinho opened this issue Nov 20, 2018 · 9 comments
Closed

Comments

@jerinho
Copy link

jerinho commented Nov 20, 2018

react-native-create-library command does not created MainActivity.java file. Only ...Module.java and ...Package.java created. And also an empty AndroidManifest.xml

Why?

@maicki
Copy link
Contributor

maicki commented Nov 20, 2018

Hey, did you create the library from master? The version on npm unfortunately is really outdated: #78

@jerinho
Copy link
Author

jerinho commented Nov 21, 2018

created it directly from command. here some details

  • react-native-create-library@3.1.2
  • npm : 6.4.1
  • react-native-cli : 2.0.1
  • react-native: 0.57.5

@maicki
Copy link
Contributor

maicki commented Nov 21, 2018

Try out creating it from master. As said above the npm version is pretty old, unfortunately I don't have the permissions to push a new version.

@jerinho
Copy link
Author

jerinho commented Nov 22, 2018

ok. now i'm understand. we need to create a react-native app first using react-native init before react-native-create-library. they should fix the documentation

@jerinho
Copy link
Author

jerinho commented Nov 22, 2018

Hey, did you create the library from master? The version on npm unfortunately is really outdated: #78

how do you know i used npm?. because i'm pretty sure i used yarn

@maicki
Copy link
Contributor

maicki commented Nov 22, 2018

What I meant is if you installed react-native-create-library from the npm registry. yarn uses the npm registry to install packages.

@jerinho
Copy link
Author

jerinho commented Nov 26, 2018

ok. now i'm understand. we need to create a react-native app first using react-native init before react-native-create-library. they should fix the documentation

unfortunately this not working either. it asking for gradle-wrappers version of 2.2 and revert build tools version from latest one to the oldest one possible. if i change it back manually the compilation fail saying com.reactlibrary.MyActivity not found

@jerinho
Copy link
Author

jerinho commented Nov 26, 2018

Try out creating it from master. As said above the npm version is pretty old, unfortunately I don't have the permissions to push a new version.

i guess it's from master
npm i -g git+https://github.com/frostney/react-native-create-library.git

@jerinho
Copy link
Author

jerinho commented Nov 27, 2018

i close this issue as it's a misunderstanding. i suggest you to edit the instruction of how to use this repo. i've wrote some steps to follow in issue #89

thank you for all your responses 😺

@jerinho jerinho closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants