Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up usages of parameter default values #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

er1c
Copy link
Contributor

@er1c er1c commented Nov 30, 2018

Doesn't touch Cookie, MutableHeaders, or HttpClient since their use of default parameters is so prevalent.

sbt test

[info] Run completed in 34 seconds, 476 milliseconds.
[info] Total number of tests run: 60
[info] Suites: completed 2, aborted 0
[info] Tests: succeeded 60, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

ta-catalog

[info] Done compiling.
[success] Total time: 495 s, completed Nov 14, 2019, 10:24:36 AM

ta-webservice-api

[info] Done compiling.
[success] Total time: 285 s, completed Nov 14, 2019, 10:33:36 AM

@er1c er1c force-pushed the default-arguments branch 2 times, most recently from 5381a8c to 35819cd Compare November 14, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant