Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from argparse to click #1000

Closed
carmenbianca opened this issue Jun 11, 2024 · 0 comments · Fixed by #1084
Closed

Switch from argparse to click #1000

carmenbianca opened this issue Jun 11, 2024 · 0 comments · Fixed by #1084
Labels
priority/low Low priority

Comments

@carmenbianca
Copy link
Member

So this is fairly low-priority, but the spaghetti nature of main functions is starting to bother me.

Currently, for every subcommand, we have to implement an add_arguments and a run. Each such function is currently in its own Python file, but we could re-organise this if we wanted.

Especially as pertains annotate, these functions are not pretty. I am convinced that they can be made a lot simpler using click.

Also, click makes it lots easier to pass contexts to subcommands. Currently, a Project object is created regardless of subcommand, which is not at all needed for download (except in certain circumstances…).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant