Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad license when operator '+' is used #275

Closed
FedericoVaga opened this issue Nov 23, 2020 · 5 comments · Fixed by #314
Closed

Bad license when operator '+' is used #275

FedericoVaga opened this issue Nov 23, 2020 · 5 comments · Fixed by #314
Labels
bug Something isn't working

Comments

@FedericoVaga
Copy link

The command reuse lint reports the use of a BAD license when the '+' operator is used.

https://spdx.github.io/spdx-spec/appendix-IV-SPDX-license-expressions/#simple-license-expressions

From this page I understand that the '+' operator can be applied on any license in https://spdx.org/licenses/ (except the already marked -or-later). But despite this if I use it I get:

* Bad licenses: CERN-OHL-W-2.0+

@mxmehl
Copy link
Member

mxmehl commented Dec 7, 2020

True, + seems to be a valid SPDX expression. I wonder why we didn't support this from the start.

@silverhook, just for the sake of completeness: can you confirm that REUSE should support + expression except for the explicitely marked licenses which are supposed to use -or-later?

@silverhook
Copy link
Contributor

I confirm that + is a valid SPDX expression, which according to the spec can be applied to any license ID.

The fact that the GPL family of licenses use the -or-later (and -only) suffixes, is an exception to the above, and is a result of a request of and subsequent long discussion with the FSF. If you are interested, here is an incomplete summary into that. Prior to this change, you would also indicate GPL-2.0+ instead of GPL-2.0-or-later – the former is still valid ID if you rely on an older SPDX Spec/Licese List.

The reuse tool should acknowledge the use of the +, yes.

@mxmehl mxmehl added the bug Something isn't working label Dec 7, 2020
@mxmehl
Copy link
Member

mxmehl commented Dec 7, 2020

Thanks for the confirmation, Matija!

@carmenbianca
Copy link
Member

#314 should fix this.

@mxmehl mxmehl added this to the 0.13.0 milestone Apr 27, 2021
@mxmehl mxmehl removed this from the 0.14.0 milestone Jan 22, 2022
@brlin-tw
Copy link

Consider making a release that contains the patch of this issue as + license is quite common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants