integrate visualfsharp and fsharp master #787
Conversation
* themed link tooltip * themed link tooltip * path relative to solution * tidy up
* Don't call length if not needed * Use hasLengthGreaterThen * Use isNilOrSingleton * Use isNilOrSingleton * no double negations are not bad
* make ServiceStructure tail recursive * code cleanup
* fix 2952 - freeze on sending input to F# Interactive * safeguards
…props (#2993)
* Remove comment ifdefs
* Add Microsoft.NET.Sdk.FSharp.props
* Make TargetFrameworks work
* restore {BuildSuffix}
* rename sdk targets and props, refactor project logic into our repo
* wrong name
* Add automagic FSharp.Core reference for coreclr
* Set <DefaultProjectTypeGuid to F# project system guid
* Fix setup
* import remaining FCS code * add missing files * fix some parts of build * more FCS integration work * build fcs.dll and vs targets * revert changes to proj files * update sig files * various cleanup items * simplify #ifs * fix various tests * enable scripting testing * fix build * fix build * fix tests and build * fix tests and build * fix build * fix tests * fix tests * add diagnostic and fix coreclr build * fix printing tests * test updates * improve error logging * integrate visualfsharp master * dependency files * proj file * dependency files * fix build * fix fsi.exe in GUI mode * add end of line to source text if needed as before * fix many tests * fix remaining tests * better strong name logic to fix final test * reinstate all strong names * fix last tests * fix last test again
* use graph of option objects * fix build * fix build * try to fix tests * dont use unique stamps in unit tests
…007) * check if a referenced assembly exists before adding it into ProjectContext's metadata references * check path correctness
WHile fixing #2793 I improved the diagnostics for some assertions and remove some exceptions that were happening on the startup path I also cleaned up the logic for BinFolderOfDefaultFSharpCompiler a little and take advantage of the fact that optdata/sigdata are gone to simplify some things.
* fix 2401 * fix 2401 - test
* add library-only build and test * fix tests * Fix tests
…#3017) * add library-only build and test * Fix 1587 Internal error: TopValActualParent: does not have a parent * fix tests * Fix tests
* Remove comment ifdefs
* Add Microsoft.NET.Sdk.FSharp.props
* Make TargetFrameworks work
* restore {BuildSuffix}
* rename sdk targets and props, refactor project logic into our repo
* wrong name
* Add automagic FSharp.Core reference for coreclr
* Set <DefaultProjectTypeGuid to F# project system guid
* Fix setup
* Resolve magic
* resolve magic
* Remove comment ifdefs
* Add Microsoft.NET.Sdk.FSharp.props
* Make TargetFrameworks work
* restore {BuildSuffix}
* rename sdk targets and props, refactor project logic into our repo
* wrong name
* Add automagic FSharp.Core reference for coreclr
* Set <DefaultProjectTypeGuid to F# project system guid
* Fix setup
* Resolve magic
* resolve magic
* Minor target rework due to crosstargetting changes. Always copy fsharp.core for desktop builds
* Remove comment ifdefs
* Add Microsoft.NET.Sdk.FSharp.props
* Make TargetFrameworks work
* restore {BuildSuffix}
* rename sdk targets and props, refactor project logic into our repo
* wrong name
* Add automagic FSharp.Core reference for coreclr
* Set <DefaultProjectTypeGuid to F# project system guid
* Fix setup
* Update sdk props
* Remove comment ifdefs
* Add Microsoft.NET.Sdk.FSharp.props
* Make TargetFrameworks work
* restore {BuildSuffix}
* rename sdk targets and props, refactor project logic into our repo
* wrong name
* Add automagic FSharp.Core reference for coreclr
* Set <DefaultProjectTypeGuid to F# project system guid
* Fix setup
* Update sdk props
* Typo for net461
* Remove comment ifdefs
* Add Microsoft.NET.Sdk.FSharp.props
* Make TargetFrameworks work
* restore {BuildSuffix}
* rename sdk targets and props, refactor project logic into our repo
* wrong name
* Add automagic FSharp.Core reference for coreclr
* Set <DefaultProjectTypeGuid to F# project system guid
* Fix setup
* Revert https://github.com/Microsoft/visualfsharp/pull/2530/commits ---
* seal implementers * fix QA tests * fix QA tests * fix QA tests * fix QA tests
properly integrate visualfsharp/master
apply recent PRs over proper integration of visual fsharp master
Integrate visualfsharp master
|
@dsyme slack says this apparently blocks dotnet/fsharp#3469. |
|
I'm more concerned that it's blocker for ionide/FsAutoComplete#183 and support of |
|
@Krzysztof-Cieslak Yes that is basically what I meant, sorry. |
|
It's close to being done. The problem is that the various software enginering procedures no longer quite align - e.g. this repo uses packages/... without version numbers, while Microsoft/visualfsharp uses pnes with verison numbers. I ws trying to wade my way through it but realised that I'd be better off aligning more things I'll try to get to it tomorrow |
|
@dsyme thanks. If there is anything reasonable to help you with let me know. I'm basically blocked by this as well (I'm not even trying to update FAKE5 to SDK2 when I see such issues open). |
If I understand this blocks .NET Standard 2.0 consumption in Ionide. Will definitely make this top priority. I'm not sure I'll get time before Monday though |
Yep, that is accurate. |
|
I'm closing this request and am going to do this another way. I will make it possible to do builds of FCS in the visualfsharp repo, but I will also make sure it is possible to build just FCS in this repo. But this repo will be a more-or-less direct subset of Microsoft/visualfsharp. just the parts needed for FCS, its documentation etc. |
The last ever nasty big integration (finally round-tripping the previous alignments)