Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImplementationFiles to FSharpCheckFileResults #810

Conversation

vasily-kirichenko
Copy link
Contributor

No description provided.

@vasily-kirichenko
Copy link
Contributor Author

I ported the changed @dsyme asked for.

@dsyme
Copy link
Contributor

dsyme commented Oct 3, 2017

This got integrated via git pull http://github.com/Microsoft/visualfsharp master

@dsyme dsyme closed this Oct 3, 2017
@alfonsogarciacaro
Copy link
Contributor

@ncave This is the PR that enabled using ParseAndCheckFileInProject in Fable. Do you think any of this can be reused so we can implement the method in your FCS Fork and enable it in Fable REPL?

@ncave
Copy link
Contributor

ncave commented Nov 21, 2018

@alfonsogarciacaro Not by itself, no. What it actually requires is using the incremental builder, or some variation of it, which we didn't need to do so far in the Fable REPL, as we didn't have a use case for it. We can continue the conversation over there, so we don't preempt this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants