Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include 'runtimes' folder in netcore release archive #373

Closed
TOTBWF opened this issue Apr 16, 2019 · 1 comment · Fixed by #376
Closed

Include 'runtimes' folder in netcore release archive #373

TOTBWF opened this issue Apr 16, 2019 · 1 comment · Fixed by #376
Assignees
@enricosada

Comments

@TOTBWF
Copy link

TOTBWF commented Apr 16, 2019

After downloading the netcore release archive and trying to run it on OSX, dotnet complains with

Error:
  An assembly specified in the application dependencies manifest (fsautocomplete.deps.json) was not found:
    package: 'System.Data.SqlClient', version: '4.6.0'
    path: 'runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll'

However, the version compiled from source runs just fine because of the presence of the assembly.
@TOTBWF TOTBWF changed the title Include runtimes folder in netcore release archive Include 'runtimes' folder in netcore release archive Apr 16, 2019
@Krzysztof-Cieslak
Copy link
Member

CC: @enricosada

@enricosada enricosada self-assigned this Apr 16, 2019
@TOTBWF TOTBWF mentioned this issue Apr 16, 2019
Merged
TOTBWF pushed a commit to TOTBWF/emacs-fsharp-mode that referenced this issue Apr 18, 2019
Update Makefile to build netcore FSAutoComplete
39212bb 
FSAutoComplete has the option to run purely on
netcore, which would remove a dependency on mono
for some users. The reason behind the FSAutoComplete
version bump is that previous versions were not
properly building their release archives.
(See ionide/FsAutoComplete#373)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enricosada enricosada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'runtimes' folder to netcore release archive TOTBWF/FsAutoComplete
3 participants
@enricosada @Krzysztof-Cieslak @TOTBWF