AdaptiveLSPServer improvements: Autocomplete Speed, Typechecking Progress, Memory Usage #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be an issue with bigger projects but this needs discussion how it should work
openFilesToCheckedDeclarations was causing memory leaks by using the AMap.map(tick) function. This has some strange caching of functions that was effectively saving every variation.
TheAngryByrd
force-pushed
the
typecheck-progress
branch
from
99121a7 to
91762db
Compare
TheAngryByrd
commented
Nov 9, 2022
|
Will need ionide/LanguageServerProtocol#43 to go out before hand |
TheAngryByrd
changed the title
TheAngryByrd
force-pushed
the
typecheck-progress
branch
from
b18e913 to
2c03a17
Compare
TheAngryByrd
commented
Jan 11, 2023
TheAngryByrd
force-pushed
the
typecheck-progress
branch
from
4a6881c to
5fbb292
Compare
TheAngryByrd
force-pushed
the
typecheck-progress
branch
from
2d64d0e to
0b93c98
Compare
baronfel
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes that I've slowly worked on as part making Ionide for my giant work project.
This also incorporates all the autocomplete perf changes from #1028 and #1035
Autocomplete Speed up
This speeds up autocompletion by holding onto a cache of previous results and re-using it. On a giant file (4k lines long) I get pretty snappy autocompletes that are still accurate.
TypeChecking progress:
I've tied into the Workspace Progress LSP endpoints and gives updates to what file is currently being typechecked.
Additionally I am able to show the progress and how many files left to typecheck, however this is limited to the
TextDocumentDidSave. In other cases it's an indeterminate progress bar.This progress types are based on client capabilities type for the progress capabilities.
Memory usage
Seems like all the major memory usage is in the compiler now.