Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptive refactorings and fixing code lens reference setting #1052

Merged
merged 3 commits into from
Feb 4, 2023
Merged

Adaptive refactorings and fixing code lens reference setting #1052

merged 3 commits into from
Feb 4, 2023

Conversation

TheAngryByrd
Copy link
Member

  1. First commit is about refactoring the AdaptiveLSPServer, renaming, and cleaning up oddities.
  2. Is fixing an issue where for codelens. If you have the references disabled, it will still attempt to retrieve references. This is important to fix as Find All References is fairly slow and computationally expensive especially for large projects.

image

@baronfel
Copy link
Contributor

baronfel commented Feb 4, 2023

I am hoping the ubuntu leg is intermittent red - I'd like to see some green before merging.

@baronfel baronfel merged commit 78d1fd4 into ionide:main Feb 4, 2023
@baronfel
Copy link
Contributor

baronfel commented Feb 4, 2023

Good stuff, will start working on a release

@TheAngryByrd TheAngryByrd mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheAngryByrd @baronfel