Make test explorer work with fsac tests and fix an expecto test detection #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
commented
Sep 17, 2023
There was a problem hiding this comment.
Did self review.
cc @farlee2121 so you can see how awesome this is.
| Expecto (>= 9.0 < 10.0) - restriction: || (== net6.0) (== net7.0) (&& (== netstandard2.0) (>= netcoreapp3.1)) (&& (== netstandard2.1) (>= netcoreapp3.1)) | ||
| FSharp.Core (>= 4.6.2) - restriction: || (== net6.0) (== net7.0) (&& (== netstandard2.0) (>= netcoreapp3.1)) (&& (== netstandard2.1) (>= netcoreapp3.1)) | ||
| System.Collections.Immutable (>= 6.0) - restriction: || (== net6.0) (== net7.0) (&& (== netstandard2.0) (>= netcoreapp3.1)) (&& (== netstandard2.1) (>= netcoreapp3.1)) | ||
| YoloDev.Expecto.TestSdk (0.14.2) |
There was a problem hiding this comment.
Expecto Test SDK added support for Filter Expressions in 0.14.2
| @@ -33,15 +33,15 @@ let tests state = | |||
| [ | |||
| testCaseAsync | |||
| "no parsing/checking errors" | |||
| (async { | |||
| <| async { | |||
There was a problem hiding this comment.
Not a necessary change but showing that we're still missing some extremely complex syntax pattern match to be able to see the runnable part on the side. (See nothing next to async ({ .. }) vs async <| having an icon)
Comment on lines
+542
to
+545
| let dotnetRestore dir = async { | ||
| let! r = runProcess (DirectoryInfo(dir).FullName) "dotnet" "restore -v d" | ||
| return expectExitCodeZero r | ||
| } |
There was a problem hiding this comment.
Async.map actually makes it hard to get correct stack tracing.
This was throwing on debug attaching for some reason. I was getting:
Assembly loaded during TaskRun (NuGet.Build.Tasks.GetRestoreSettingsTask): System.Diagnostics.StackTrace, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a (location: C:\\Program Files\\dotnet\\shared\\Microsoft.NETCore.App\\7.0.11\\System.Diagnostics.StackTrace.dll, MVID: a66c8790-3b61-402e-b635-09e18e1fbd38, AppDomain: [Default])
System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
at System.ArgumentNullException.Throw(String paramName)
at System.IO.Path.Combine(String path1, String path2)
at NuGet.Common.NuGetEnvironment.GetFolderPath(NuGetFolderPath folder)
at NuGet.Configuration.XPlatMachineWideSetting..ctor()
at NuGet.Build.Tasks.GetRestoreSettingsTask.<>c.<.cctor>b__85_0()
at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
at System.Lazy`1.CreateValue()
at NuGet.Build.Tasks.RestoreSettingsUtils.ReadSettings(String solutionDirectory, String restoreDirectory, String restoreConfigFile, Lazy`1 machineWideSettings, SettingsLoadingContext settingsLoadContext)
at NuGet.Build.Tasks.GetRestoreSettingsTask.Execute()
Done executing task \"GetRestoreSettingsTask\" -- FAILED.
Comment on lines
+248
to
+255
| let args = | ||
| [ | ||
| CLIArguments.Printer (Expecto.Impl.TestPrinters.summaryWithLocationPrinter defaultConfig.printer) | ||
| CLIArguments.Verbosity logLevel | ||
| // CLIArguments.Parallel | ||
| ] | ||
|
|
||
| runTestsWithCLIArgsAndCancel cts.Token args fixedUpArgs tests |
There was a problem hiding this comment.
Mechanical shift to new API.
| @@ -276,7 +276,6 @@ let tests state = testList (nameof(Server)) [ | |||
|
|
|||
| testSequenced <| testList "contesting" [ | |||
| let projectDir = inTestCases "Project" | |||
| dotnetRestore projectDir.Value |> Async.RunSynchronously | |||
There was a problem hiding this comment.
This was causing using the new debug feature to fail. Guessing this was here before we started doing restores in the serverInit functions.
TheAngryByrd
force-pushed
the
make-test-explorer-work-with-fsac-tests
branch
from
76c32f5 to
36e4c5c
Compare
TheAngryByrd
commented
Sep 17, 2023
Comment on lines
+145
to
+146
| | Case, SynExpr.Paren(expr = SynExpr.App(argExpr = SynExpr.ComputationExpr _)) | ||
| | Case, SynExpr.Paren(expr = (SynExpr.Lambda _)) -> |
There was a problem hiding this comment.
Updated Pattern matching to find testCaseAsync "test paren" (async { ... })
|
Tangent: I've noticed mac builds failing on so many repositories, makes me think they're busted for dotnet right now. |
TheAngryByrd
changed the title
TheAngryByrd
changed the title
nojaf
pushed a commit
to nojaf/FsAutoComplete
that referenced
this pull request
Nov 3, 2023
…tion (ionide#1165) * update Expecto to use FilterExpression * fix ability to debug some tests * unset yolodev dependency restriction * expand expecto test detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 841c093
This pull request improves the test suite for the LSP features of FsAutoComplete by fixing a build error, reformatting a test file, and enhancing the test setup and runner functions. It also updates the
paket.dependenciesfile and removes a redundant call todotnetRestorein one of the test files.🤖 Generated by Copilot at 841c093
📦🛠️🧹
WHY
Project work to make Test Run Debugger usable in FSAC.
debug-test-from-ionide2.mp4
HOW
🤖 Generated by Copilot at 841c093
YoloDev.Expecto.TestSdkto 0.14.2 inpaket.dependencies(link)runTestsWithCLIArgsAndCancelfunction inProgram.fs(link)DirectoryInfotype and the-v doption for thedotnet restorecommand inHelpers.fs(link)dotnetRestoreinServer.Tests.fs(link)EmptyFileTests.fsto use the<|operator and remove extra blank lines for readability and consistency (link, link, link, link)