Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugger regression #1230

Merged
merged 3 commits into from
Feb 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -6,6 +6,13 @@

* [Analyzers: Update analyzers support to 0.24.0](https://github.com/fsharp/FsAutoComplete/pull/1229) (thanks @nojaf)


## [0.70.0] - 2024-02-06

### Changed

* [Update Ionide.ProjInfo and enable support for Reference Assemblies where they exist](https://github.com/fsharp/FsAutoComplete/pull/1228)

## [0.69.0] - 2024-01-14

### Added
14 changes: 12 additions & 2 deletions src/FsAutoComplete/CommandResponse.fs
Original file line number Diff line number Diff line change
@@ -146,17 +146,27 @@ module CommandResponse =
Version: string
FullPath: string }

/// a structure containing the data needed to render project trees for a solution explorer
type ProjectResponse =
{ Project: ProjectFilePath
{
/// the fully qualified path to the project file
Project: ProjectFilePath
/// the list of fully-qualified paths of the files in the project
Files: List<SourceFilePath>
/// the fully-qualified path to the primary output (executable, library, etc.) of the project.
/// note that this is _not_ a reference assembly
Output: string
ProjectReferences: List<ProjectReference>
PackageReferences: List<PackageReference>
References: List<ProjectFilePath>
OutputType: ProjectOutputType
/// a useful subset of project file properties for this permutation of the project
Info: ProjectResponseInfoDotnetSdk
/// the list of items in the project, such as compile items, content items, etc. this
/// should be a superset of data like the Files, Project/Package References, etc
Items: List<ProjectResponseItem>
AdditionalInfo: Map<string, string> }
AdditionalInfo: Map<string, string>
}

and ProjectOutputType =
| Library
2 changes: 1 addition & 1 deletion src/FsAutoComplete/LspServers/AdaptiveServerState.fs
Original file line number Diff line number Diff line change
@@ -852,7 +852,7 @@ type AdaptiveState(lspClient: FSharpLspClient, sourceTextFactory: ISourceTextFac
let ws =
{ ProjectFileName = projectFileName
ProjectFiles = responseFiles
OutFileOpt = Option.ofObj projectOption.ResolvedTargetPath
OutFileOpt = Option.ofObj projectOption.TargetPath
References = references
Extra = projectOption
ProjectItems = projViewerItemsNormalized.Items

Unchanged files with check annotations Beta

<Project Sdk="Microsoft.NET.Sdk">

Check failure on line 1 in test/FsAutoComplete.Tests.Lsp/FsAutoComplete.Tests.Lsp.fsproj

GitHub Actions / Build on macos-latest for 6.0

FSAC.lsp.Ionide WorkspaceLoader.Unused Declarations.project.used this

There should be no unused value diagnostic at cursor position. Expected list to have length 0, but length was 1. Seq: [|{ Range = { Start = { Line = 3 Character = 9 } End = { Line = 3 Character = 13 } } Severity = Some Hint Code = Some "FSAC0003" CodeDescription = None Source = Some "FSAC" Message = "This value is unused" RelatedInformation = Some [||] Tags = Some [|Unnecessary|] Data = None }|] at FsAutoComplete.Tests.UnusedDeclarationsTests.checkUsageAt@36-2.Invoke(Document _arg2) in /Users/runner/work/FsAutoComplete/FsAutoComplete/test/FsAutoComplete.Tests.Lsp/UnsedDeclarationsTests.fs:line 51 at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvoke[T,TResult](AsyncActivation`1 ctxt, TResult result1, FSharpFunc`2 part2) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 510 at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 112 --- End of stack trace from previous location --- at Microsoft.FSharp.Control.AsyncResult`1.Commit() in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 454
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net6.0</TargetFrameworks>