-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for test explorer #893
Conversation
@nojaf what I meant by a new type is that the PlainNotification type is serialized and sent to VSCode (and other clients) as a Essentially, IMO we should be reducing the amount of usage of PlainNotification in favor of typed responses all the time, and integrating that into callsites in Ionide as we change that contract. |
…fication and PlainNotification.
@baronfel this first test worked on my machine. |
These tests are exactly what I had in mind! As we expand detection support we can of course flesh them out 👍 |
This is great - the failing windows tests are the flaky ones that are not related to this effort. I'm good to merge this. Once it merges we can look at the Ionide side of things (which will likely need a slight tweak as the shape of the new notification has changed slightly from the original pass of this work). |
Following up on #796, I'm trying to address the remaining work.
@baronfel, I changed the parameter type to a new type, but I'm guessing there is a bit more to it.
Could you point me in the right direction on what I need to do with
TestDetectedNotification
?