Fix #950: Index out of bounds #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: Comparison with line 0 instead of line 1 Note: While Exception with stack trace was shown, there was no impact on actual FSAC usage (-> FSAC didn't crash). Exception was just shown in log Note: Request still fails because no prev char, but it fails as expected. Previously failure was unwanted failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: Comparison with line 0 instead of line 1
Note: While Exception with stack trace was shown, there was no impact on actual FSAC usage (-> FSAC didn't crash). Exception was just displayed in log
Note: Request still returns failure because no prev char. But now it's a deliberate failure (vs. prev: index out of bounds)
Includes a rewrite of tests to use example code directly in tests instead of external files