Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inlay Parameter Hint tuple params & pipe from right #957

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

Booksbaum
Copy link
Contributor

Fix ionide/ionide-vscode-fsharp#1714: param names are assigned to args in order, not based on actual param

prev:
TuplePrev
now:
TupleNow


Fix/Improve naming when tuple elements param, but single variable as input

prev:
TupleVarPrev
(single param name because issue above)
now:
TupleVarNow

Note: There's an issue when param is single tuple variable (not tuple elements):
TupleIssue
-> no param hint for gamma

FCS doesn't provide name for gamma, but instead treats param as tuple with two unnamed elements.
Same issue for tooltips: doesn't show param name: dotnet/fsharp#10441

Note: Just for normal tuple. param name for struct tuple does work...

Note: in first example param name for tuple input (beta) is displayed:
TupleNow
That's because param beta is generic, tuple is only used as input


Fix: Doesn't show param name for unit input

prev:
UnitPrev
now:
UnitNow



Fix: Param Hint at function when arg piped in from right

prev:
PipePrev
now:
PipeNow

Booksbaum added 2 commits July 5, 2022 12:35
…nstead of matching param

Fix: No Param Hint for unit arg

Fix: Param Hint at function when arg piped in from right
@baronfel baronfel merged commit 31dd3fc into ionide:main Jul 5, 2022
@Booksbaum Booksbaum deleted the InlayHintParamsTuple branch July 5, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuples mess up inlay parameter hints
2 participants