use dotnet that spawned FSAC as an input to SDK discovery #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may fix some cases presented in ionide/ionide-vscode-fsharp#1697.
Instead of delegating to the probing in proj-info, when we've been launched by a
dotnetcommand (which IMO is the common case - only scenario when that's not the case is a global .NET tool install) we can use the path to thatdotnetbinary to skip the probing in proj-info that finds the dotnet binary. We still do SDK probing, but we remove a big case of potential errors.