Update to an FCS that understands F# 7 #1043

baronfel · 2022-11-21T14:38:13Z

Notable Changes:

Our workarounds module could be deleted
the type suffix for arrays was changed from [] to array
SRTP type annotations were changed from ^ to '
Several codefixes (and tests) needed to be (temporarily) removed due to upstream issues that have been logged.

Test failure categories:

We also seem to have an issue in completions where the full set of known names is being reported, and the namespace-probing isn't happening (e.g. so Regex isn't recognized and System.Text isn't offered as a suggested open). - punting to followup.
! codefixes aren't returning (same with many others)
interpolation codefixes aren't finding an AST - anonymous modules aren't returning a good parse tree? - issue raised and resolved upstream already
Implement interface codefix tests are broken because of upstream issue (logged already), but the functionality mostly works - issue raised

.vscode/launch.json

baronfel · 2022-11-21T15:43:32Z

global.json

-        "rollForward": "latestPatch"
-    }
-}
+  "sdk": {


TODO: add this back when we get a 6.0-compatible package.

src/FsAutoComplete.Core/CodeGeneration.fs

src/FsAutoComplete.Core/Commands.fs

src/FsAutoComplete.Core/DocumentationFormatter.fs

src/FsAutoComplete.Core/UntypedAstUtils.fs

src/FsAutoComplete.Core/Workaround/ServiceParseTreeWalk.fs

baronfel · 2022-11-21T15:48:25Z

test/FsAutoComplete.Tests.Lsp/CompletionTests.fs

@@ -497,10 +497,11 @@ let autoOpenTests state =
      | Ok None -> failtest "Request none"
      | Ok (Some res) ->
        Expect.isFalse res.IsIncomplete "Result is incomplete"
-        let ci = res.Items |> Array.find (fun c -> c.Label = word)
+        let ci = res.Items |> Array.tryFind (fun c -> c.Label = word)


debugging here to try and figure out why we can't get all the completions.

test/FsAutoComplete.Tests.Lsp/CoreTests.fs

test/FsAutoComplete.Tests.Lsp/ExtensionsTests.fs

src/FsAutoComplete.Core/FsAutoComplete.Core.fsproj

edgarfgp · 2022-12-14T13:00:05Z

@baronfel FSharp.Core 7 will now print array instead of []. Does FsAutoComplete some specific logic that needs to be removed?

baronfel · 2022-12-17T16:35:54Z

The current blocked test is FSAC.lsp.Ionide WorkspaceLoader.FSharpLspServer.Rename Tests.Across projects.Rename from usage across projects - it's failing to load TestCases\\RenameTest\\CrossProject\\LibB\\LibB.fsproj successfully.

baronfel · 2022-12-17T16:36:22Z

@edgarfgp that change has already been taken into account in this PR - the default formatting changed and so I updated the tests' expectations to match 👍

baronfel · 2022-12-17T17:39:11Z

Status:

Failed:    2
Errored:  89

The failures and errors are mostly in the autocomplete namespace suggestions tests, so once that's fixed it should just be a bit of whack-a-mole.

nojaf · 2023-01-18T09:34:33Z

Hi @baronfel, could you use any help with this?
Is there anything blocking here? Like waiting for a dependency to update?
Or is the remaining work about fixing those last failing tests?

vzarytovskii · 2023-01-18T11:05:14Z

Hi @baronfel, could you use any help with this?
Is there anything blocking here? Like waiting for a dependency to update?
Or is the remaining work about fixing those last failing tests?

I would imagine it waits for new FCS update, the one without msbuild dependency. Should be out same time with 7.0.200

nojaf · 2023-01-18T12:14:28Z

Would there be any reason not to use 43.7.200-preview.22569.1 if the MSBuild dependency thing indeed blocks everything?
I imagine all the dependencies would also need to be bumped to that preview version.

nojaf · 2023-01-19T13:43:03Z

Sorry, that was a bad suggestion, I just noticed that the preview FSC has a dependency on an FSharp.Core version that is not on NuGet:

fixed with ionide#1043 (Upgrade to dotnet 7 & new FCS) (see ionide#1037 (comment) )

This removes the 6.0 target while we wait for updated packages on NuGet.

…r rebase

…st expectation to match reality

also disable the 'without type annotation' interface generation entirely due to dotnet/fsharp#14698

…being LongIdents instead of Idents in the AST now

test/FsAutoComplete.Tests.Lsp/FsAutoComplete.Tests.Lsp.fsproj

baronfel · 2023-02-19T22:43:22Z

There's one more test failure around the new ^-formatting for types, but other than that I think we might be good to go.

fixed with ionide#1043 (Upgrade to dotnet 7 & new FCS) (see ionide#1037 (comment) )

baronfel force-pushed the fcs-.net7 branch 2 times, most recently from 3d6d767 to 06f3b15 Compare November 21, 2022 15:13

baronfel commented Nov 21, 2022

View reviewed changes

kant2002 reviewed Nov 23, 2022

View reviewed changes

src/FsAutoComplete.Core/FsAutoComplete.Core.fsproj Show resolved Hide resolved

edgarfgp mentioned this pull request Dec 12, 2022

Quick fix for removing _ when using a union case with not data #1034

Closed

baronfel mentioned this pull request Feb 5, 2023

The compiler crashes when trying to use the code analyzer #1050

Closed

baronfel force-pushed the fcs-.net7 branch 2 times, most recently from 0ca82cb to aab7140 Compare February 5, 2023 20:07

Booksbaum mentioned this pull request Feb 12, 2023

Enhancements for Find All References & Rename #1037

Merged

This was referenced Feb 14, 2023

F# 7 Support ionide/ionide-vscode-fsharp#1802

Closed

FCS 43.7.200 has odd behavior for modules with errors dotnet/fsharp#14757

Closed

Booksbaum added a commit to Booksbaum/FsAutoComplete that referenced this pull request Feb 17, 2023

Remove Active Pattern FullName bug example

c60a552

fixed with ionide#1043 (Upgrade to dotnet 7 & new FCS) (see ionide#1037 (comment) )

baronfel added 10 commits February 19, 2023 12:09

WIP F# 7 update

e48faee

This removes the 6.0 target while we wait for updated packages on NuGet.

fix NuGet.Frameworks delay-load

edb3b84

fix a bunch of autocomplete tests

d6a2835

workaround net7 test framework binding to nuget.frameworks

406ea33

Fixup a few packaging errors after rebase

edd87c9

supply an actually working fcsCompletionContext that disappeared afte…

bac3ddc

…r rebase

default to adaptive LSP server

995afe0

change ordering of implemented interface property getter/setter in te…

abfec9b

…st expectation to match reality

adjust to new FCS AST for property get/set on interface generation

8e1f844

also disable the 'without type annotation' interface generation entirely due to dotnet/fsharp#14698

silence failing tests with a marker to reenable later

e2d41e4

baronfel added 2 commits February 19, 2023 12:14

fix formatting

6ef6f71

update to new stable FCS

a89df50

baronfel force-pushed the fcs-.net7 branch from e556b8d to a89df50 Compare February 19, 2023 18:21

baronfel added 3 commits February 19, 2023 13:17

fix c# lambda-to-fun codefix after the AST changed for operations

c33fa6c

fix bang-to-value dereference codefix to account for operation names …

c4bffef

…being LongIdents instead of Idents in the AST now

formatting

fedc55f

baronfel marked this pull request as ready for review February 19, 2023 19:26

baronfel commented Feb 19, 2023

View reviewed changes

test/FsAutoComplete.Tests.Lsp/FsAutoComplete.Tests.Lsp.fsproj Outdated Show resolved Hide resolved

Fix a few build issues and comment things

a87984b

baronfel changed the title ~~WIP F# 7 update~~ Update to an FCS that understands F# 7 Feb 19, 2023

make the completion autoopen tests ignored for now

d896058

ensure we no longer render hat-types at all in signature rendering

6b798f9

baronfel merged commit 2ca73e9 into ionide:main Feb 20, 2023

baronfel deleted the fcs-.net7 branch February 20, 2023 03:39

Booksbaum added a commit to Booksbaum/FsAutoComplete that referenced this pull request Feb 21, 2023

Remove Active Pattern FullName bug example

a3adf6d

fixed with ionide#1043 (Upgrade to dotnet 7 & new FCS) (see ionide#1037 (comment) )

Booksbaum added a commit to Booksbaum/FsAutoComplete that referenced this pull request Mar 3, 2023

Remove Active Pattern FullName bug example

19702b1

fixed with ionide#1043 (Upgrade to dotnet 7 & new FCS) (see ionide#1037 (comment) )

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to an FCS that understands F# 7 #1043

Update to an FCS that understands F# 7 #1043

baronfel commented Nov 21, 2022 •

edited

Loading

baronfel Nov 21, 2022

baronfel Nov 21, 2022

edgarfgp commented Dec 14, 2022

baronfel commented Dec 17, 2022

baronfel commented Dec 17, 2022

baronfel commented Dec 17, 2022

nojaf commented Jan 18, 2023

vzarytovskii commented Jan 18, 2023

nojaf commented Jan 18, 2023

nojaf commented Jan 19, 2023

baronfel commented Feb 19, 2023

Update to an FCS that understands F# 7 #1043

Update to an FCS that understands F# 7 #1043

Conversation

baronfel commented Nov 21, 2022 • edited Loading

baronfel Nov 21, 2022

Choose a reason for hiding this comment

baronfel Nov 21, 2022

Choose a reason for hiding this comment

edgarfgp commented Dec 14, 2022

baronfel commented Dec 17, 2022

baronfel commented Dec 17, 2022

baronfel commented Dec 17, 2022

nojaf commented Jan 18, 2023

vzarytovskii commented Jan 18, 2023

nojaf commented Jan 18, 2023

nojaf commented Jan 19, 2023

baronfel commented Feb 19, 2023

baronfel commented Nov 21, 2022 •

edited

Loading