Recover type checking inherit ctor arg expression (#8653)

* Recover type checking inherit ctor expression

* Add test

Author: auduchinok

src/fsharp/TypeChecker.fs

@@ -13982,7 +13982,12 @@ module MutRecBindingChecking =
                         | Phase2AInherit (synBaseTy, arg, baseValOpt, m) ->
                             let baseTy, tpenv = TcType cenv NoNewTypars CheckCxs ItemOccurence.Use envInstance tpenv synBaseTy
                             let baseTy = baseTy |> convertToTypeWithMetadataIfPossible g
-                            let inheritsExpr, tpenv = TcNewExpr cenv envInstance tpenv baseTy (Some synBaseTy.Range) true arg m
+                            let inheritsExpr, tpenv =
+                                try 
+                                   TcNewExpr cenv envInstance tpenv baseTy (Some synBaseTy.Range) true arg m
+                                with e ->
+                                    errorRecovery e m
+                                    mkUnit g m, tpenv
                             let envInstance = match baseValOpt with Some baseVal -> AddLocalVal cenv.tcSink scopem baseVal envInstance | None -> envInstance
                             let envNonRec = match baseValOpt with Some baseVal -> AddLocalVal cenv.tcSink scopem baseVal envNonRec | None -> envNonRec
                             let innerState = (tpenv, envInstance, envStatic, envNonRec, generalizedRecBinds, preGeneralizationRecBinds, uncheckedRecBindsTable)

tests/service/Common.fs

@@ -312,8 +312,8 @@ let getSymbolUses (source: string) =
     typeCheckResults.GetAllUsesOfAllSymbolsInFile() |> Async.RunSynchronously
 
 let getSymbols (source: string) =
-    getSymbolUses source
-    |> Array.map (fun symbolUse -> symbolUse.Symbol)
+    let symbolUses = getSymbolUses source
+    symbolUses |> Array.map (fun symbolUse -> symbolUse.Symbol)
 
 
 let getSymbolName (symbol: FSharpSymbol) =
@@ -329,8 +329,10 @@ let getSymbolName (symbol: FSharpSymbol) =
 
 
 let assertContainsSymbolWithName name source =
-    getSymbols source
-    |> Array.choose getSymbolName
+    let symbols = getSymbols source
+    let names = symbols |> Array.choose getSymbolName
+
+    names
     |> Array.contains name
     |> shouldEqual true
 

tests/service/EditorTests.fs

@@ -1361,3 +1361,14 @@ type R =
     y
 """
     assertContainsSymbolWithName "y" source
+
+
+[<Test>]
+let ``Inherit ctor arg recovery`` () =
+    let source = """
+    type T() as this =
+        inherit System.Exception('a', 'a')
+
+        let x = this
+    """
+    assertContainsSymbolWithName "x" source